Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lookbehind simplifies transformIgnorePatterns & ensures correctness #4

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

mlrawlings
Copy link
Member

Description

Uses a negative lookbehind regex for transformIgnorePatterns which ignores anything under node_modules that isn't a .marko file. This fixes an issue where the old implementation (which only handled ignoring packages in your project's package.json) wouldn't transform .marko files in nested dependencies.

It's also a lot simpler than iterating over packages.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey self-requested a review April 10, 2020 14:42
@mlrawlings mlrawlings merged commit 993b466 into master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants